Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12557#discussion_r60536140 --- Diff: repl/src/main/scala/org/apache/spark/repl/Signaling.scala --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.repl + +import org.apache.spark.SparkContext +import org.apache.spark.internal.Logging +import org.apache.spark.util.{Signaling => USignaling} + +private[repl] object Signaling extends Logging { + + /** + * Register a SIGINT handler, that terminates all active spark jobs or terminates + * when no jobs are currently running. + * This makes it possible to interrupt a running shell job by pressing Ctrl+C. + */ + def cancelOnInterrupt(ctx: SparkContext): Unit = USignaling.register("INT") { + if (!ctx.statusTracker.getActiveJobIds().isEmpty) { --- End diff -- So I don't see this behaviour in my Python shell or my regular bash shell: > holden@yogapanda:~/repos/spark$ python > Python 2.7.6 (default, Jun 22 2015, 17:58:13) > [GCC 4.8.2] on linux2 > Type "help", "copyright", "credits" or "license" for more information. > >>> > KeyboardInterrupt > >>> > KeyboardInterrupt > >>> > But if it matches other interactive shells than that seems fine.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org