Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11812#issuecomment-212822658 Is the problem that the input vector may have a very large norm, causing the dot product with other vectors to be Infinity? There's a little, opposite problem: dividing by a very small norm upfront might introduce a fair bit of imprecision in the result. It's the simpler thing to do and better some imprecision (in a context where it's not all that essential) than bad results.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org