Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r60667528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -121,8 +123,11 @@ class SessionCatalog(
currentDb = db
}
- def getDefaultDBPath(db: String): String = {
- System.getProperty("java.io.tmpdir") + File.separator + db + ".db"
+ def createDatabasePath(dbName: String, path: Option[String]): String = {
+ val dbPath = path.map(new Path(_)).getOrElse {
+ new Path(new Path(System.getProperty("java.io.tmpdir")),
dbName.toLowerCase() + ".db")
+ }
+ dbPath.toString.stripSuffix(File.separator)
--- End diff --
This is to remove the last `File.separator`, if existing. Based on the Hive
behavior, the location does not have it, not matter whether the original
user-input location has it or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
