Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60700056
--- Diff: core/src/main/scala/org/apache/spark/util/SignalLogger.scala ---
@@ -17,44 +17,20 @@
package org.apache.spark.util
-import org.apache.commons.lang3.SystemUtils
import org.slf4j.Logger
-import sun.misc.{Signal, SignalHandler}
/**
* Used to log signals received. This can be very useful in debugging
crashes or kills.
- *
- * Inspired by Colin Patrick McCabe's similar class from Hadoop.
*/
private[spark] object SignalLogger {
--- End diff --
I kept it because logging is called from more than one place (two to be
precise)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
