Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60700632
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -51,11 +88,8 @@ private[spark] object Signaling extends Logging {
// register old handler, will receive incoming signals while this
handler is running
Signal.handle(signal, prevHandler)
- val escalate = actions.asScala forall { action =>
- !action()
- }
-
- if(escalate) {
+ val escalate = actions.asScala.forall { action => !action() }
--- End diff --
sure, I initially had comments but thought they were overkill since the
behaviour can be deducted from the comments in the register() method. I'll add
some more info
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
