Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12601#discussion_r60721164 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -244,7 +244,11 @@ final class DataFrameWriter private[sql](df: DataFrame) { bucketSpec = getBucketSpec, options = extraOptions.toMap) - dataSource.write(mode, df) + dataSource.providingClass.newInstance() match { + case jdbc: execution.datasources.jdbc.DefaultSource => --- End diff -- It looks a new method is introduced. I think we don't necessarily introduce this new function but use the existing interfaces `CreatableRelationProvider` in `interfaces`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org