Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12600#discussion_r60778555 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -187,11 +187,11 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with Logging with Serializ /** * Prepare a SparkPlan for execution. It's idempotent. */ - final def prepare(): Unit = { + final def prepare(): Unit = synchronized { --- End diff -- This looks dangerous. Child's `doPrepare` is wrapped by `parent's synchronized` without any comment mentioning it. If Child's `doPrepare` starts a new thread and calls `prepare` in it, we may have some dead-lock race.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org