Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213725055
This looks correct to my eyes. The Since annotation is in place as a
non-test class; the existing test classes are moved into the test source root.
The parent pom now declares available dependencies on the test or non-test
artifacts from this module. Everything refers to the new module, and most
dependencies are non-test (which implicitly includes the test artifacts)
because they need `@Since` directly. I agree with renaming the module too. This
LGTM as far as I know, except possibly the question of whether the class
constructors are over-annotated (CC @mengxr). I wouldn't mind another look from
@dbtsai or @vanzin or @JoshRosen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
