Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12626#discussion_r60831742
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala 
---
    @@ -71,7 +71,9 @@ object CurrentOrigin {
       }
     }
     
    +// scalastyle:off
    --- End diff --
    
    I tried overriding equals but it seems to break things pretty badly because 
it seemingly overrides the case-class equals which would be auto-generated in 
subclasses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to