Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12222#discussion_r60923441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -277,9 +277,18 @@ class InMemoryCatalog extends ExternalCatalog {
catalog(db).tables(table).partitions(spec)
}
+ /**
+ * List the metadata of all partitions that belong to the specified
table, assuming it exists.
+ *
+ * A partial partition spec may optionally be provided to filter the
partitions returned.
+ * For instance, if there exist partitions (a='1', b='2'), (a='1',
b='3') and (a='2', b='4'),
+ * then a partial spec of (a='1') will return the first two only.
+ * TODO: Currently partialSpec is not used for memory catalog and it
returns all the partitions.
--- End diff --
Can we throw exception instead of returning all the partitions if a
partition spec is given to an in-memory catalog? Silently returning wrong
answer can be dangerous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
