Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11919#discussion_r60968178
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -656,13 +656,15 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
previousItemFactors.unpersist()
itemFactors.setName(s"itemFactors-$iter").persist(intermediateRDDStorageLevel)
// TODO: Generalize PeriodicGraphCheckpointer and use it here.
+ val deps = itemFactors.dependencies
--- End diff --
So it needs to be outside of the conditional because if I put it inside of
the conditional it won't be in scope. I could make it an Option and capture the
deps there but I think that would be a little convoluted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
