Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12560#issuecomment-214490075
@wangmiao1981 I tend to agree with @yanboliang. I don't think adding
instrumentation is critical enough to break the `train` method signature, even
if it is `DeveloperApi`.
I think we should just log what we can unobtrusively, and perhaps at a
later stage further instrumentation can be added in a performant way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
