Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1147#discussion_r15710615
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
    @@ -137,6 +137,185 @@ trait HashJoin {
     }
     
     /**
    + * Constant Value for Binary Join Node
    + */
    +object HashOuterJoin {
    +  val DUMMY_LIST = Seq[Row](null)
    +  val EMPTY_LIST = Seq[Row]()
    --- End diff --
    
    Please use `Seq.empty[Row]` inline instead of this variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to