Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/12655#issuecomment-214617772
@kayousterhout
I'll update the unit test and JIRA, PR descriptions to use the simpler
example.
As for the `createAncestorShuffleMapStages` way, I think it will have a
risk of `StackOverflowError` for a long job because the master branch version
of `getAncestorShuffleDependencies` finds descendants first, which would have a
lot of ancestors with long linage, and if we immediately create the shuffle
stage there by the `newOrUsedShuffleStage` method, which builds all ancestor
stages by recursive-call fashion, the `StackOverflowError` will be thrown.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
