Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61045778
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
@@ -644,8 +644,10 @@ class CheckpointSuite extends TestSuiteBase with
DStreamCheckpointTester
val mappedStream = fileStream.map(s => {
val i = s.toInt
if (i == 3) {
- while (CheckpointSuite.batchThreeShouldBlockIndefinitely) {
- Thread.sleep(Long.MaxValue)
+ if (CheckpointSuite.batchThreeShouldBlockIndefinitely) {
+ // It's not a good idea to let the thread run forever
+ // as resource won't be correctly released
+ Thread.sleep(6000)
--- End diff --
OK, how about changing the text to "should block a long time" then? as long
as this is more than long enough for the driver to shutdown it seems to be in
line with the intent of the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
