Github user tdas commented on the pull request:

    https://github.com/apache/spark/pull/1361#issuecomment-50934313
  
    LGTM!!! 
    
    My only concern in the documentation, but that we can try fixing 
independently (but we have to). And the unit test uses files, which is not the 
best way to test. Integrating with streamign unit tests is going to be a bit 
involved, so lets leave it for the future, 1.2, as more streaming + mllib stuff 
gets added.
    
    This is very cool start to a hopefully new path. :D @mengxr Go ahead and 
merge it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to