Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12421#discussion_r61298823 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala --- @@ -177,6 +177,8 @@ case class WindowExec( case e @ WindowExpression(function, spec) => val frame = spec.frameSpecification.asInstanceOf[SpecifiedWindowFrame] function match { + case MakeDecimal(AggregateExpression(f, _, _, _), prec, scale) => --- End diff -- Oh, my bad. You're right. I missed recovering that. I'll remove this. WindowExec.scala is solid and there is no need to be changed.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org