Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1720#discussion_r15722274
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -42,6 +42,18 @@ class DecisionTreeSuite extends FunSuite with
LocalSparkContext {
assert(accuracy >= requiredAccuracy)
}
+ def validateRegressor(
+ model: DecisionTreeModel,
+ input: Seq[LabeledPoint],
+ requiredMSE: Double) {
+ val predictions = input.map(x => model.predict(x.features))
+ val squaredError = predictions.zip(input).map { case (prediction,
expected) =>
+ (prediction - expected.label) * (prediction - expected.label)
--- End diff --
I think this is the correct Spark style. But it maybe better if we use
~~~
val err = prediction - expected.label
err * err
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
