Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11919#discussion_r61316331
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -1306,4 +1310,30 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
* satisfies this requirement, we simply use a type alias here.
*/
private[recommendation] type ALSPartitioner =
org.apache.spark.HashPartitioner
+
+ /**
+ * Private function to clean up all of the shuffles files from the
dependencies and their parents.
+ */
+ private[spark] def cleanShuffleDependencies[T](sc: SparkContext, deps:
Seq[Dependency[_]],
+ blocking: Boolean = false): Unit = {
+ // If there is no reference tracking we skip clean up.
+ if (sc.cleaner.isEmpty) {
+ return
+ }
+ val cleaner = sc.cleaner.get
+ /**
+ * Clean the shuffles & all of its parents.
+ */
+ def cleanEagerly(dep: Dependency[_]): Unit = {
--- End diff --
Does this need to be an internal def as opposed to just a closure? could
also be more straightforward to read
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
