Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12734#discussion_r61318397
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -264,9 +265,16 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder {
           } else {
             SaveMode.ErrorIfExists
           }
    -      CreateTableUsingAsSelect(table, provider, temp, Array.empty, None, 
mode, options, query)
    +
    +      val partitionColumnNames =
    +        Option(ctx.partitionColumnNames)
    +          .map(visitIdentifierList(_).toArray)
    +          .getOrElse(Array.empty[String])
    +
    +      CreateTableUsingAsSelect(
    +        table, provider, temp, partitionColumnNames, bucketSpec, mode, 
options, query)
         } else {
    -      val struct = Option(ctx.colTypeList).map(createStructType)
    +      val struct = Option(ctx.colTypeList()).map(createStructType)
    --- End diff --
    
    oh, sorry. PARTITIONED BY and CLUSTERED BY are both associated with CREATE 
TABLE USING AS SELECT rule. So, for CREATE TABLE USING, if PARTITIONED BY or 
CLUSTERED PY is provided, we already throw an exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to