Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12612#issuecomment-215304306 This looks pretty good to me. We should get it to pass tests and then merge it asap. Some of the comments can be addressed later.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org