Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12560#discussion_r61384326
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala ---
@@ -85,6 +85,13 @@ private[ml] class Instrumentation[E <: Estimator[_]]
private (
}
/**
+ * Logs the value with customized name field.
+ */
+ def logNamedValue(name: String, num: Long): Unit = {
--- End diff --
Just a note for posterity, I thought about whether this should be a Double
to support arbitrary values (maybe in future we want to log some training
metrics such as log loss or other error, for example), but then the formatting
would be off for integers. So if we need that in future we can just create an
overloaded method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
