Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12752#discussion_r61462767
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
 ---
    @@ -195,10 +195,13 @@ class FileInputDStream[K, V, F <: NewInputFormat[K, 
V]](
           )
           logDebug(s"Getting new files for time $currentTime, " +
             s"ignoring files older than $modTimeIgnoreThreshold")
    -      val filter = new PathFilter {
    +      val newFileFilter = new PathFilter {
             def accept(path: Path): Boolean = isNewFile(path, currentTime, 
modTimeIgnoreThreshold)
           }
    -      val newFiles = fs.listStatus(directoryPath, 
filter).map(_.getPath.toString)
    +      val directories = fs.globStatus(directoryPath, 
directoryFilter).map(_.getPath)
    --- End diff --
    
    Got it, right, so I can still specify a directory and it will match that 
directory only in the first globStatus. That makes sense. (Nit in the line 
below: you don't need the extra braces and will probably have to remove the 
space before 'dir'.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to