Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61486213
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy() {
arrayCopy.pointTo(arrayDataCopy, Platform.BYTE_ARRAY_OFFSET,
sizeInBytes);
return arrayCopy;
}
+
+ public int[] toPrimitiveIntArray() {
+ int[] result = new int[numElements];
+ Platform.copyMemory(baseObject, baseOffset + 4 + 4 * numElements,
+ result, Platform.INT_ARRAY_OFFSET, 4 * numElements);
+ return result;
+ }
+
+ public double[] toPrimitiveDoubleArray() {
+ double[] result = new double[numElements];
+ Platform.copyMemory(baseObject, baseOffset + 4 + 4 * numElements,
+ result, Platform.DOUBLE_ARRAY_OFFSET, 8 * numElements);
+ return result;
+ }
+
+ public static UnsafeArrayData fromPrimitiveArray(int[] arr) {
+ int offsetRegionSize = 4 * arr.length;
+ int valueRegionSize = 4 * arr.length;
+ int totalSize = 4 + offsetRegionSize + valueRegionSize;
+ byte[] data = new byte[totalSize];
--- End diff --
@mengxr We only use off-heap memory (direct buffer) for page (tens of MB),
otherwise always use on-heap arrays. Off heap memory may be less efficient to
handle smaller allocates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
