Github user markhamstra commented on the pull request:

    https://github.com/apache/spark/pull/12655#issuecomment-215556785
  
    I'm fine with the change in https://github.com/apache/spark/pull/8923  I'm 
looking at refactoring of `newOrUsedShuffleStage` that may effectively turn it 
into just `newShuffleStage`, so putting the `Used` check/guard in 
`getShuffleMapStage` where @suyanNone has it is a reasonable thing from my 
perspective.  Along with Kay's suggested augmentation of the tests, I think 
that's good enough for the first, simple PR.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to