Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12767#discussion_r61508260
--- Diff: python/pyspark/ml/tests.py ---
@@ -616,6 +622,7 @@ def test_save_load(self):
tvsModel.save(tvsModelPath)
loadedModel = TrainValidationSplitModel.load(tvsModelPath)
self.assertEqual(loadedModel.bestModel.uid, tvsModel.bestModel.uid)
+ self.assertEqual(len(loadedModel.validationMetrics),
len(tvsModel.validationMetrics))
--- End diff --
It would be better to compare each `validationMetric` in the list not only
the length of `validationMetrics` cc @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
