Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12720#discussion_r61520106
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
 ---
    @@ -38,20 +38,24 @@ abstract class SubqueryExpression extends Expression {
        */
       def plan: QueryPlan[_]
     
    -  /**
    -   * Updates the query with new logical plan.
    -   */
    +  /** Updates the query with new logical plan. */
       def withNewPlan(plan: LogicalPlan): SubqueryExpression
    +
    +  /** The correlated conditions that connects the sub-query to its parent 
query. */
    +  def conditions: Seq[Expression]
    +
    +  protected def conditionString: String = conditions.mkString("[", " && ", 
"]")
     }
     
     /**
      * A subquery that will return only one row and one column. This will be 
converted into a physical
      * scalar subquery during planning.
      *
    - * Note: `exprId` is used to have unique name in explain string output.
    + * Note: `exprId` is used to have a unique name in explain string output.
      */
     case class ScalarSubquery(
         query: LogicalPlan,
    +    conditionOption: Option[Seq[Expression]] = None,
    --- End diff --
    
    conditionOption -> conditions ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to