Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12768#discussion_r61523748 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala --- @@ -42,13 +42,14 @@ object TypeUtils { } def checkForSameTypeInputExpr(types: Seq[DataType], caller: String): TypeCheckResult = { - if (types.distinct.size > 1) { - TypeCheckResult.TypeCheckFailure( - s"input to $caller should all be the same type, but it's " + - types.map(_.simpleString).mkString("[", ", ", "]")) - } else { - TypeCheckResult.TypeCheckSuccess - } + types.foreach ( t => + if (!t.sameType(types.head)){ --- End diff -- (FYI, if you run `./dev/run_tests` (this triggers style checking first) or `./build/sbt scalastyle` before submitting commits, this will shows up the comments I left)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org