Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12773#discussion_r61547437
--- Diff: core/src/main/scala/org/apache/spark/NewAccumulator.scala ---
@@ -197,7 +199,7 @@ private[spark] object AccumulatorContext {
* TODO: Don't use a global map; these should be tied to a SparkContext
(SPARK-13051).
*/
@GuardedBy("AccumulatorContext")
- val originals = new java.util.HashMap[Long,
jl.ref.WeakReference[NewAccumulator[_, _]]]
+ private val originals = new java.util.HashMap[Long,
jl.ref.WeakReference[NewAccumulator[_, _]]]
--- End diff --
Have you considered using ConcurrentHashMap for originals ?
The two calls in register() can then be replaced with putIfAbsent().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
