Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r61619036
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -117,101 +112,3 @@ case class ExplainCommand(
("Error occurred during query planning: \n" +
cause.getMessage).split("\n").map(Row(_))
}
}
-
-/**
- * A command to list the column names for a table. This function creates a
- * [[ShowColumnsCommand]] logical plan.
- *
- * The syntax of using this command in SQL is:
- * {{{
- * SHOW COLUMNS (FROM | IN) table_identifier [(FROM | IN) database];
- * }}}
- */
-case class ShowColumnsCommand(table: TableIdentifier) extends
RunnableCommand {
- // The result of SHOW COLUMNS has one column called 'result'
- override val output: Seq[Attribute] = {
- AttributeReference("result", StringType, nullable = false)() :: Nil
- }
-
- override def run(sparkSession: SparkSession): Seq[Row] = {
- sparkSession.sessionState.catalog.getTableMetadata(table).schema.map {
c =>
- Row(c.name)
- }
- }
-}
-
-/**
- * A command to list the partition names of a table. If the partition spec
is specified,
- * partitions that match the spec are returned. [[AnalysisException]]
exception is thrown under
- * the following conditions:
- *
- * 1. If the command is called for a non partitioned table.
- * 2. If the partition spec refers to the columns that are not defined as
partitioning columns.
- *
- * This function creates a [[ShowPartitionsCommand]] logical plan
- *
- * The syntax of using this command in SQL is:
- * {{{
- * SHOW PARTITIONS [db_name.]table_name [PARTITION(partition_spec)]
- * }}}
- */
-case class ShowPartitionsCommand(
- table: TableIdentifier,
- spec: Option[TablePartitionSpec]) extends RunnableCommand {
- // The result of SHOW PARTITIONS has one column called 'result'
- override val output: Seq[Attribute] = {
- AttributeReference("result", StringType, nullable = false)() :: Nil
- }
-
- private def getPartName(spec: TablePartitionSpec, partColNames:
Seq[String]): String = {
- partColNames.map { name =>
- PartitioningUtils.escapePathName(name) + "=" +
PartitioningUtils.escapePathName(spec(name))
- }.mkString(File.separator)
- }
-
- override def run(sparkSession: SparkSession): Seq[Row] = {
- val catalog = sparkSession.sessionState.catalog
- val db = table.database.getOrElse(catalog.getCurrentDatabase)
- if (catalog.isTemporaryTable(table)) {
- throw new AnalysisException("SHOW PARTITIONS is not allowed on a
temporary table: " +
- s"${table.unquotedString}")
- } else {
- val tab = catalog.getTableMetadata(table)
- /**
- * Validate and throws an [[AnalysisException]] exception under the
following conditions:
- * 1. If the table is not partitioned.
- * 2. If it is a datasource table.
- * 3. If it is a view or index table.
- */
- if (tab.tableType == CatalogTableType.VIEW ||
- tab.tableType == CatalogTableType.INDEX) {
- throw new AnalysisException("SHOW PARTITIONS is not allowed on a
view or index table: " +
- s"${tab.qualifiedName}")
- }
- if (!DDLUtils.isTablePartitioned(tab)) {
- throw new AnalysisException("SHOW PARTITIONS is not allowed on a
table that is not " +
- s"partitioned: ${tab.qualifiedName}")
- }
- if (DDLUtils.isDatasourceTable(tab)) {
- throw new AnalysisException("SHOW PARTITIONS is not allowed on a
datasource table: " +
- s"${tab.qualifiedName}")
- }
- /**
- * Validate the partitioning spec by making sure all the referenced
columns are
- * defined as partitioning columns in table definition. An
AnalysisException exception is
- * thrown if the partitioning spec is invalid.
- */
- if (spec.isDefined) {
- val badColumns =
spec.get.keySet.filterNot(tab.partitionColumns.map(_.name).contains)
- if (badColumns.nonEmpty) {
- throw new AnalysisException(
- s"Non-partitioning column(s) [${badColumns.mkString(", ")}]
are " +
- s"specified for SHOW PARTITIONS")
- }
- }
- val partNames =
- catalog.listPartitions(table, spec).map(p => getPartName(p.spec,
tab.partitionColumnNames))
- partNames.map { p => Row(p) }
- }
- }
-}
--- End diff --
Moved to `tables.scala`, not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
