Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215859307
Just realized that it doesn't make sense to say `RDD` in the parameter
name. This is implementation detail and we actually return the factors as
DataFrames. So, shall we rename it to `intermediateStorageLevel` and
`finalStorageLevel` instead? We might want to update `ALS.train` to take a
Dataset instead and update the param names there too (in a follow-up PR).
Other than the param names, this looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
