Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12814#discussion_r61670779 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java --- @@ -338,9 +338,10 @@ public UnsafeArrayData copy() { } public static UnsafeArrayData fromPrimitiveArray(int[] arr) { - if (arr.length > (Integer.MAX_VALUE - 4) / 8) { + int limit = (Integer.MAX_VALUE - 4) / 8; + if (arr.length > limit) { throw new UnsupportedOperationException("Cannot convert this array to unsafe format as " + - "it's too big."); + "its length (" + arr.length + ") exceeds " + limit + "."); --- End diff -- Oh, duh sorry about that.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org