Github user jdesmet commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9095#discussion_r61675971
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -395,6 +395,10 @@ private[yarn] class YarnAllocator(
           val executorId = executorIdCounter.toString
     
           assert(container.getResource.getMemory >= resource.getMemory)
    --- End diff --
    
    Note that wrong vcore accounting in Yarn can affect system integrity due to 
over-scheduling the CPU. It is mandatory to have this working correctly if 
spark has to play a nice citizen on yarn (together with other scheduled apps or 
itself).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to