Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11919#discussion_r61708547 --- Diff: mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala --- @@ -520,6 +488,81 @@ class ALSSuite } } +class ALSCleanerSuite extends SparkFunSuite { + test("Clean shuffles") { + val conf = new SparkConf() + val localDir = Utils.createTempDir() + val tempDir = Utils.createTempDir() + def getAllFiles: Set[File] = + FileUtils.listFiles(localDir, TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE).asScala.toSet + try { + conf.set("spark.local.dir", localDir.getAbsolutePath) + conf.set("spark.shuffle.manager", "sort") + val sc = new SparkContext("local[2]", "test", conf) + try { + sc.setCheckpointDir(tempDir.getAbsolutePath) + // Test checkpoint and clean parents + val filesBefore = getAllFiles --- End diff -- Do we expect files generated automatically by `sc`? If so, we should leave a comment here and explain there are some initial files created by `sc.setCheckpointDir`. Otherwise, we don't need `filesBefore` because it should be empty.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org