Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12830#discussion_r61805011
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala 
---
    @@ -635,6 +642,122 @@ class SparkSession private(
     
     object SparkSession {
     
    +  /**
    +   * Builder for [[SparkSession]].
    +   */
    +  class Builder {
    +
    +    private[this] val options = new 
scala.collection.mutable.HashMap[String, String]
    +
    +    /**
    +     * Sets a name for the application, which will be shown in the Spark 
web UI.
    +     *
    +     * @since 2.0.0
    +     */
    +    def appName(name: String): Builder = config("spark.app.name", name)
    +
    +    /**
    +     * Sets a config option. Options set using this method are 
automatically propagated to
    +     * both [[SparkConf]] and SparkSession's own configuration.
    +     *
    +     * @since 2.0.0
    +     */
    +    def config(key: String, value: String): Builder = synchronized {
    +      options += key -> value
    +      this
    +    }
    +
    +    /**
    +     * Sets a config option. Options set using this method are 
automatically propagated to
    +     * both [[SparkConf]] and SparkSession's own configuration.
    +     *
    +     * @since 2.0.0
    +     */
    +    def config(key: String, value: Long): Builder = synchronized {
    +      options += key -> value.toString
    +      this
    +    }
    +
    +    /**
    +     * Sets a config option. Options set using this method are 
automatically propagated to
    +     * both [[SparkConf]] and SparkSession's own configuration.
    +     *
    +     * @since 2.0.0
    +     */
    +    def config(key: String, value: Double): Builder = synchronized {
    +      options += key -> value.toString
    +      this
    +    }
    +
    +    /**
    +     * Sets a config option. Options set using this method are 
automatically propagated to
    +     * both [[SparkConf]] and SparkSession's own configuration.
    +     *
    +     * @since 2.0.0
    +     */
    +    def config(key: String, value: Boolean): Builder = synchronized {
    +      options += key -> value.toString
    +      this
    +    }
    +
    +    /**
    +     * Sets a list of config options based on the given [[SparkConf]].
    +     *
    +     * @since 2.0.0
    +     */
    +    def config(conf: SparkConf): Builder = synchronized {
    +      conf.getAll.foreach { case (k, v) => options += k -> v }
    +      this
    +    }
    +
    +    /**
    +     * Sets the Spark master URL to connect to, such as "local" to run 
locally, "local[4]" to
    +     * run locally with 4 cores, or "spark://master:7077" to run on a 
Spark standalone cluster.
    +     *
    +     * @since 2.0.0
    +     */
    +    def master(master: String): Builder = config("spark.master", master)
    +
    +    /**
    +     * Enables Hive support, including connectivity to a persistent Hive 
metastore, support for
    +     * Hive serdes, and Hive user-defined functions.
    +     *
    +     * @return 2.0.0
    +     */
    +    def enableHiveSupport(): Builder = synchronized {
    +      if (hiveClassesArePresent) {
    +        config(CATALOG_IMPLEMENTATION.key, "hive")
    +      } else {
    +        throw new IllegalArgumentException(
    +          "Unable to instantiate SparkSession with Hive support because " +
    +            "Hive classes are not found.")
    +      }
    --- End diff --
    
    probably as a separate pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to