Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1369#issuecomment-50955760
Hey on this one - it's helpful to see what this looks like - but my
instinct is actually to move away from scala-logging entirely. We can upgrade
ourselves, but all that does is force our users downstream to have to upgrade
(even if they aren't using ml stuff at all), causing the same annoying headache
as breeze is causing us. I'd prefer to just remove the (now very small) use of
scala-logging and just continue to use the slf4j API directly. The mian benefit
of scala-logging is the use of compile time macro's for some performance gain,
but we've never in the entire history of Spark had any performance issues
related to logging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
