Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61928352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,22 @@ case class ProcessingTimeExecutor(processingTime:
ProcessingTime, clock: Clock =
s"${intervalMs} milliseconds, but spent ${realElapsedTimeMs}
milliseconds")
}
- /** Return the next multiple of intervalMs */
+ /** Return the next multiple of intervalMs
+ *
+ * e.g. for intervalMs = 100
+ * nextBatchTime(0) = 100
+ * nextBatchTime(1) = 100
+ * ...
+ * nextBatchTime(99) = 100
+ * nextBatchTime(100) = 200
+ * nextBatchTime(101) = 200
+ * ...
+ * nextBatchTime(199) = 200
+ * nextBatchTime(200) = 300
+ *
+ * Note, this way, we'll get nextBatchTime(nextBatchTime(0)) = 200,
rather than = 0
+ * */
def nextBatchTime(now: Long): Long = {
- (now - 1) / intervalMs * intervalMs + intervalMs
+ now / intervalMs * intervalMs + intervalMs
--- End diff --
I see. I think your approach is better. Thanks for your clarifying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
