Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12872#discussion_r62016658
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala 
---
    @@ -57,6 +67,35 @@ class SQLViewSuite extends QueryTest with SQLTestUtils 
with TestHiveSingleton {
         }
       }
     
    +  test("error handling: fail if the temp view name contains the database 
prefix") {
    +    // Full qualified table name is not allowed
    +    val e = intercept[AnalysisException] {
    +      sql("CREATE OR REPLACE TEMPORARY VIEW default.myabcdview AS SELECT * 
FROM jt").collect()
    +    }
    +    assert(e.message.contains("It is not allowed to add database prefix"))
    +  }
    +
    +  test("error handling: disallow IF NOT EXISTS for CREATE TEMPORARY VIEW") 
{
    +    // Full qualified table name is not allowed
    --- End diff --
    
    Wrong comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to