Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12693#discussion_r62049836
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
    @@ -640,12 +640,14 @@ class CheckpointSuite extends TestSuiteBase with 
DStreamCheckpointTester
             val fileStream = ssc.textFileStream(testDir.toString)
             // Make value 3 take a large time to process, to ensure that the 
driver
             // shuts down in the middle of processing the 3rd batch
    -        CheckpointSuite.batchThreeShouldBlockIndefinitely = true
    +        CheckpointSuite.batchThreeShouldBlockALongTime = true
             val mappedStream = fileStream.map(s => {
    --- End diff --
    
    Yeah feel free to also make that style change while you're here. The ( and 
{ are redundant and just needs a {


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to