Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12829#discussion_r62121226
--- Diff: core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java
---
@@ -389,12 +389,6 @@ public long cleanUpAllAllocatedMemory() {
consumers.clear();
}
- for (MemoryBlock page : pageTable) {
--- End diff --
@davies in L382 we null out the `pageTable` so this loop doesn't do
anything. However, I don't think we should delete this code. Should we just
remove L382? Is this a cause for memory leaks?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
