Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12897#discussion_r62121313 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -73,8 +73,11 @@ class ExpressionParserSuite extends PlanTest { // Numeric literals without a space between the literal qualifier and the alias, should not be // interpreted as such. An unresolved reference should be returned instead. - // TODO add the JIRA-ticket number. assertEqual("1SL", Symbol("1SL")) + assertEqual("1 asL", Literal(1).as("asL")) + assertEqual("1as L", Symbol("1as").as("L")) + assertEqual("(1E0 + 1)L", (Literal(1.0) + Literal(1)).as("L")) + intercept("1.0L", "Ambiguous alias 'L' encountered") --- End diff -- `1asL` will be treated as an identifier, right?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org