Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62176096
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
@@ -98,13 +97,12 @@ private[spark] class Pool(
}
override def getSortedTaskSetQueue: ArrayBuffer[TaskSetManager] = {
- var sortedTaskSetQueue = new ArrayBuffer[TaskSetManager]
- val sortedSchedulableQueue =
-
schedulableQueue.asScala.toSeq.sortWith(taskSetSchedulingAlgorithm.comparator)
- for (schedulable <- sortedSchedulableQueue) {
- sortedTaskSetQueue ++= schedulable.getSortedTaskSetQueue
- }
- sortedTaskSetQueue
+ schedulableQueue
--- End diff --
It compiles because of the cast, which might fail at runtime. Then maybe
the tests didn't run? or didn't cover this code path actually
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
