Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12914#discussion_r62285930
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -58,6 +61,9 @@ def __init__(self):
if defaultValueStr is not None:
template += '''
self._setDefault($name=$defaultValueStr)'''
+ doc += '''(Default $friendlyDefault)'''
+ if friendlyDefault is None:
+ friendlyDefault = defaultValueStr
--- End diff --
Except for ```seed```, other params have the same ```defaultValueStr``` and
```friendlyDefault```. I don't think it's necessary to use two variables
because ```defaultValueStr``` is already string type and can be used in the doc.
For param ```seed```, I think ```hash(type(self).__name__)``` is more clear
than ```hash of type name``` for users to understand the default value of this
param.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
