Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12790#discussion_r62380680 --- Diff: python/pyspark/ml/pipeline.py --- @@ -89,9 +87,9 @@ def setParams(self, stages=None): setParams(self, stages=None) Sets params for Pipeline. """ - if stages is None: - stages = [] kwargs = self.setParams._input_kwargs + if stages is None: + kwargs['stages'] = [] --- End diff -- Do we need this? Now that we've got `getOrDefault` inside of `getStages` it shouldn't be necessary provided we use the get function.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org