Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12627#discussion_r62402319
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -129,7 +131,9 @@ class KMeansModel private[ml] (
@Since("2.0.0")
def computeCost(dataset: Dataset[_]): Double = {
SchemaUtils.checkColumnType(dataset.schema, $(featuresCol), new
VectorUDT)
- val data = dataset.select(col($(featuresCol))).rdd.map { case
Row(point: Vector) => point }
+ val data = dataset.select(col($(featuresCol))).rdd.map { case
Row(point: Vector) =>
+ OldVectors.fromML(point)
--- End diff --
@mengxr Implicit conversion doesn't work things like those. We still need
manually convert them. But I agree that some of the code can be simplified by
implicit which I will push in the next commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
