Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12975#discussion_r62449958
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -157,6 +157,9 @@ case class DropFunction(
throw new AnalysisException(s"Specifying a database in DROP
TEMPORARY FUNCTION " +
s"is not allowed: '${databaseName.get}'")
}
+ if (FunctionRegistry.builtin.functionExists(functionName)) {
--- End diff --
I also think what you said is valid. If so, I think we also need to provide
users a way to recover the built-in function, if they dropped it for any
purpose.
This PR is just to make our behavior consistent with Hive and the
mainstream RDBMS. Normally, we do not allow users to drop the built-in
functions. I am fine if we allow users to drop the built-in functions.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
