Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62670600
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,7 +45,9 @@ statement
| ALTER DATABASE identifier SET DBPROPERTIES tablePropertyList
#setDatabaseProperties
| DROP DATABASE (IF EXISTS)? identifier (RESTRICT | CASCADE)?
#dropDatabase
| createTableHeader ('(' colTypeList ')')? tableProvider
- (OPTIONS tablePropertyList)?
#createTableUsing
+ (OPTIONS tablePropertyList)?
+ (PARTITIONED BY partitionColumnNames=identifierList)?
+ bucketSpec?
#createTableUsing
| createTableHeader tableProvider
--- End diff --
The reason for not combining them is that the first is a `CREATE TABLE`
statement (and has column and no query) and that the second one is `CREATE
TABLE ... AS` statement (which has no columns and a query). This way the parser
will catch input that both defines columns and a query.
We could also check this in the `SparkSqlAstBuilder`...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
