Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/11157#discussion_r62743444
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -46,6 +46,7 @@ private[mesos] trait MesosSchedulerUtils extends Logging {
--- End diff --
The additions to this file seem overly complex for just grabbing port
resources. Maybe all this complexity is necessary, but I'm skeptical. I
started in on it and got lost. I don't have time to review it all today.
Please ensure there is no more room for simplification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
