GitHub user ericl opened a pull request: https://github.com/apache/spark/pull/13035
[SPARK-15259] Sort time metric should not include spill and record insertion time ## What changes were proposed in this pull request? After SPARK-14669 it seems the sort time metric includes both spill and record insertion time. This makes it not very useful since the metric becomes close to the total execution time of the node. We should track just the time spent for in-memory sort, as before. ## How was this patch tested? Verified metric in the UI, also unit test on UnsafeExternalRowSorter. cc @davies You can merge this pull request into a Git repository by running: $ git pull https://github.com/ericl/spark fix-metrics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/13035.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13035 ---- ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org