Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12936#discussion_r62785734
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
@@ -29,9 +29,18 @@ class SQLMetric(val metricType: String, initValue: Long
= 0L) extends Accumulato
// We may use -1 as initial value of the accumulator, if the accumulator
is valid, we will
// update it at the end of task and the value will be at least 0. Then
we can filter out the -1
// values before calculate max, min, etc.
- private[this] var _value = initValue
+ private var _value = initValue
--- End diff --
I'm a little worried about removing the `[this]` here, how about we pass in
`initValue` and `zeroValue`, and assign `initValue` to `_value`? Then we don't
need to mutate `_value` out of the `this` scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
